fix(discovery): detect static sites that carry a package.json#5
Merged
Merged
Conversation
A folder with a package.json that has no recognizable server framework and no dev/start script, but an index.html at its root, was misclassified as a non-runnable "node-server". It is really a static site that merely keeps a manifest (e.g. a build dep or metadata) — so it never got a Start button. Now it is detected as html5-static and served like any other static site (npx serve). Adds a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Un folder con
package.jsonsin framework de servidor reconocible y sin scriptdev/start, pero conindex.htmlen la raíz, se clasificaba como unnode-serverno lanzable → nunca obtenía botón Start. En realidad es un sitio estático que solo guarda un manifiesto (una dep de build o metadatos).Ahora se detecta como
html5-staticy se sirve como cualquier estático (npx serve).Por qué
En el workspace real,
fervon(sitio estático con unpackage.jsonque solo trae@resvg/resvg-js, sin scripts) aparecía como tarjeta muerta sin Start. Esto lo arregla de forma genérica, sin hardcodear nombres.Verificación
discovery.test.js(un estático con manifiesto →type: html5-static,runnable: true).npm test→ 67/67 verdesnpm run build→ verde🤖 Generated with Claude Code