Establish baseline: fix ESLint violations and Docker Compose nginx DNS

[Copilot]

Baseline verification revealed 6 ESLint violations in React components and nginx failing to start in Docker Compose due to DNS resolution timing.

ESLint Fixes

react-hooks/set-state-in-effect violations - Refactored synchronous setState calls in effects:

• AssessmentReport.tsx: Moved derived state to useMemo, wrapped API calls in async function with cancellation
• ProjectDetail.tsx: Extracted async load function to avoid synchronous setState in effect body

react-hooks/rules-of-hooks violations - Moved hook calls outside conditional blocks:

• Layout.tsx & MigrationExecution.tsx: Called useMsal() unconditionally, then wrapped usage in try-catch

react-refresh/only-export-components violation - Split ThemeContext.tsx:

• Extracted context definition to createThemeContext.ts
• Extracted hook to useTheme.ts
• Provider component remains in ThemeContext.tsx for Fast Refresh compatibility

Docker Compose Fix

nginx was failing with "host not found in upstream 'api'" because Docker's embedded DNS (127.0.0.11) isn't available at nginx startup. Fixed by forcing runtime DNS resolution:

resolver 127.0.0.11 valid=30s;
set $upstream_api api:8080;

location /api/ {
    proxy_pass http://$upstream_api;
    # ...
}

All services (db, api, web) now start successfully.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• 127.0.0.11
  • Triggering command: REDACTED, pid is -1 (packet block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[JoshLuedeman]

Closing to start fresh — will re-approach Phase 0 issues from a clean slate.