fix(ref:1601): Relax FormValueControl implementation#1602
Open
ThiloAschebrock wants to merge 1 commit intoJsDaddy:developfrom
Open
fix(ref:1601): Relax FormValueControl implementation#1602ThiloAschebrock wants to merge 1 commit intoJsDaddy:developfrom
ThiloAschebrock wants to merge 1 commit intoJsDaddy:developfrom
Conversation
Relaxes the Angular signal form interface implementation to avoid conflicts with other directives or the host component, e.g., for required and readonly.
Author
|
@andriikamaldinov1 @NepipenkoIgor could I please ask for a review of this PR? |
ThiloAschebrock
commented
Feb 18, 2026
| public errors = input<readonly WithOptionalField<ValidationError>[]>([]); | ||
| public disabled = input<boolean>(false); | ||
| public disabled = input(false, { transform: booleanAttribute }); | ||
| public touched = model<boolean>(false); |
Author
There was a problem hiding this comment.
Angular will change the FormValueControl interface and break up touched, see angular/angular#67100 in Angular 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxes the Angular signal form interface implementation to avoid conflicts with other directives or the host component, e.g., for required and readonly.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1601
What is the new behavior?
Only used parts of the
FormValueControlinterface are implemented.Does this PR introduce a breaking change?
Other information
N/A