Merged
Conversation
N5N3
force-pushed
the
Drop_combine_size
branch
4 times, most recently
from
d55479d to
4fab441
Compare
thchr
reviewed
Mar 14, 2022
Collaborator
thchr
left a comment
thchr
left a comment
There was a problem hiding this comment.
Someone knowledgeable about the broadcasting machinery should review this probably - but I was reading this and figured I might as well add the few comments I had.
add `static_combine_axes` to handle Tuple correctly
1. `axes` should be static. 2. The implementation for broadcast(1) are unified) 3. simplify `broadcast_index`
Co-Authored-By: Thomas Christensen <tchr@mit.edu>
Collaborator
mateuszbaran
left a comment
mateuszbaran
left a comment
There was a problem hiding this comment.
I've done some work with broadcasting before but I'm not quite familiar with certain parts of broadcasting touched in this PR.
mateuszbaran
approved these changes
Mar 15, 2022
Collaborator
mateuszbaran
left a comment
mateuszbaran
left a comment
There was a problem hiding this comment.
I think this looks fine 👍 .
Collaborator
|
Could you bump patch version? I'd tag a new release. |
Contributor
Author
Patch version was bumped in #1001. (master is 1.4.2 at present). I guess there's no need to bump again? |
Collaborator
|
Yes, right, I didn't notice. |
Contributor
|
I think this affects HybridArrays. See: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to perform
combine_sizeduringBroadcast.instantiate:broadcast,combine_axeswill return aTuple{Vararg{SOneTo}}, thus the output size has been static.broadcast!, thedest'saxesis marked as static (if possible). If there's no size-1 dim insrc. The current generated kernal will be called.With this change, we can reduce the compile time for first broadcast by about 1/4: