Skip to content

Fix pinv for Symmetric/Hermitian wrapped SMatrix #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateuszbaran merged 2 commits into from
Mar 10, 2026
+9 −0
Merged

Fix pinv for Symmetric/Hermitian wrapped SMatrix #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a541a
Fix pinv for Symmetric/Hermitian wrapped SMatrix
aplavin Mar 9, 2026
6a2b542
Update src/pinv.jl
aplavin Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pinv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
return _pinv(A_S, atol, rtol)
end

@inline pinv(A::LinearAlgebra.HermOrSym{T,<:StaticMatrix}; kwargs...) where T = pinv(convert(similar_type(A), A); kwargs...)

@inline function _pinv(A::StaticMatrix{m,n,T}, atol::Real, rtol::Real) where T where m where n
if m == 0 || n == 0
return similar_type(A, Size(n,m))()
Expand Down
7 changes: 7 additions & 0 deletions test/pinv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,11 @@ tol = 1e-13
@test norm(N10*M10*N10 - N10) < tol
@test N10 isa StaticMatrix
@test N10 ≈ pinv(Matrix(M10))

for wrapper in (Symmetric, Hermitian)
M_w = wrapper(@SMatrix [1.0 0.5; 0.5 2.0])
N_w = pinv(M_w)
@test N_w ≈ pinv(Matrix(M_w))
@test N_w isa SMatrix{2,2,Float64}
end
end
Loading