Skip to content

Prefer header delimiters in auto detection#1186

Merged
quinnj merged 1 commit into
mainfrom
codex/fix-delim-detection-1185
Jun 11, 2026
Merged

Prefer header delimiters in auto detection#1186
quinnj merged 1 commit into
mainfrom
codex/fix-delim-detection-1185

Conversation

@quinnj

@quinnj quinnj commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Prefer delimiter candidates that also appear in the header before falling back to aggregate row consistency.
  • Add a regression test for semicolon-delimited data that uses comma decimals.
  • Update the comma-decimal docs note to reflect the improved header-aware autodetection behavior.

Root Cause

Delimiter autodetection checked candidate delimiters in a comma-first order and only required aggregate consistency across sampled rows. In files with comma decimal markers, those commas could look like a consistent delimiter even when the header clearly used semicolons.

Fixes #1185.

Validation

  • julia --project=. test/runtests.jl -> 1477/1477 passing

Co-authored by Codex

Prefer delimiter candidates that appear in the header before falling back to aggregate consistency across sampled rows. This avoids treating comma decimal markers as the delimiter when a semicolon-delimited file has a clear header.

Fixes #1185
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.79%. Comparing base (2f01e19) to head (1fc8b44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   90.75%   90.79%   +0.03%     
==========================================
  Files           9        9              
  Lines        2326     2335       +9     
==========================================
+ Hits         2111     2120       +9     
  Misses        215      215              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj quinnj merged commit 0a1fb3c into main Jun 11, 2026
11 checks passed
@quinnj quinnj deleted the codex/fix-delim-detection-1185 branch June 11, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with automatic delimiter detection

1 participant