[Not Urgent, Stylistic] Format Julia source files by JuliaFormatter#157
Open
Paalon wants to merge 2 commits intoJuliaData:masterfrom
Open
[Not Urgent, Stylistic] Format Julia source files by JuliaFormatter#157Paalon wants to merge 2 commits intoJuliaData:masterfrom
Paalon wants to merge 2 commits intoJuliaData:masterfrom
Conversation
Member
|
Does it make sense to (also?) make a precommit hook (I think that's what it's called) so this stays consistent? |
kescobo
reviewed
Jun 11, 2024
Member
kescobo
left a comment
kescobo
left a comment
There was a problem hiding this comment.
Hmm - some of these are definitely appropriate, but I'm not in love with all of them. Then again, I'm not routinely looking at this source code, so it it makes sense for you, I'm ok with it
Comment on lines
+40
to
+48
| load( | ||
| ts::TokenStream, | ||
| more_constructors::_constructor=nothing, | ||
| multi_constructors::Dict=Dict(); | ||
| dicttype::_dicttype=Dict{Any, Any}, | ||
| constructorType::Function=SafeConstructor, | ||
| ) = load( | ||
| ts, | ||
| constructorType(_patch_constructors(more_constructors, dicttype), multi_constructors), |
Contributor
There was a problem hiding this comment.
Agreed. This is the kind of JuliaFormatter thing that makes me not want to touch a code base.
This particular definition shouldn't have been in short form at all though; there's way too many arguments to make that look good, regardless of formatting. Never mind, Juliaformatter makes long form definitions equally horrible.
|
|
||
| load_all(input::IO, args...; kwargs...) = | ||
| YAMLDocIterator(input, args...; kwargs...) | ||
| load_all(input::IO, args...; kwargs...) = YAMLDocIterator(input, args...; kwargs...) |
Paalon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format Julia source files by JuliaFormatter. Everyone can format sources by executing the following in the project root directory:
Formatting styles are set in
.JuliaFormatter.toml. If there are problems or preferences, tell me.This solves #154.