Refactoring of _print(::IO, ::Pair, ::Int, ::Bool).#178
Open
Paalon wants to merge 1 commit intoJuliaData:masterfrom
Open
Refactoring of _print(::IO, ::Pair, ::Int, ::Bool).#178Paalon wants to merge 1 commit intoJuliaData:masterfrom
_print(::IO, ::Pair, ::Int, ::Bool).#178Paalon wants to merge 1 commit intoJuliaData:masterfrom
Conversation
| if (pair[2] isa AbstractDict || pair[2] isa AbstractVector) && !isempty(pair[2]) | ||
| print(io, "\n") # a line break is needed before a recursive structure | ||
| if (p1 isa AbstractDict || p1 isa AbstractVector) && !isempty(p1) | ||
| print(io, '\n') # a line break is needed before a recursive structure |
Contributor
There was a problem hiding this comment.
Are you sure writing a character is better than writing a string? I'm finding the former to be slower and having an allocation (although I have no idea why that should be necessary).
Comment on lines
+69
to
+70
| p0 = first(pair) | ||
| p1 = last(pair) |
Contributor
There was a problem hiding this comment.
These names are not so important but I would have gone for p1 and p2 rather than p0 and p1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.