Support for qr of strided inputs (non-contiguous views)#1764
Draft
evelyne-ringoot wants to merge 22 commits intoJuliaGPU:masterfrom
Draft
Support for qr of strided inputs (non-contiguous views)#1764evelyne-ringoot wants to merge 22 commits intoJuliaGPU:masterfrom
evelyne-ringoot wants to merge 22 commits intoJuliaGPU:masterfrom
Conversation
vchuravy
reviewed
Feb 9, 2023
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
Member
|
Looks like some more functions will need their signatures widened (as CI shows fallback functionality being hit). |
maleadt
added
enhancement
maleadt
changed the title
Member
|
These two https://github.com/JuliaGPU/GPUArrays.jl/blob/b2f396dabdab907866b885cd7abb647214cddace/src/host/linalg.jl#L33-L34 are implemented for dense Arrays, but not for strided arrays. So we end up https://github.com/JuliaLang/julia/blob/c0d2c574d44231dba39f90d6a6b27448f71763ca/stdlib/LinearAlgebra/src/transpose.jl#L76-L77 |
Member
|
No reason those shouldn't be an |
Contributor
Author
|
Changed this in JuliaGPU/GPUArrays.jl#452 |
Member
|
I've tagged GPUArrays 8.6.3 with this fix. |
Contributor
Author
|
Linking JuliaLang/LinearAlgebra.jl#986 for the dimension issues in the tests |
evelyne-ringoot
force-pushed
the
qr_views
branch
from
d1d5e3f to
2bd209c
Compare
maleadt
force-pushed
the
master
branch
15 times, most recently
from
5d585c4 to
c850163
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding view support for CUDA.jl QR and tests