feat : reliable idiomatic wrapper for the C library igraphs#505
Closed
mahmudsudo wants to merge 5 commits intoJuliaGraphs:masterfrom
Closed
feat : reliable idiomatic wrapper for the C library igraphs#505mahmudsudo wants to merge 5 commits intoJuliaGraphs:masterfrom
mahmudsudo wants to merge 5 commits intoJuliaGraphs:masterfrom
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
|
Hi, @mahmudsudo ! Thanks for setting this up, it is very useful work! However it is structured in a way we will not be able to merge here. Julia is organized around the paradigm of multiple dispatch, so to extend Graphs.jl with capabilities related to IGraphs.jl you do not need to make IGraphs.jl a dependency of Graphs.jl. We actually really do not want that -- Graphs.jl is supposed to be lean. Graphs.jl is already a dependency of IGraphs.jl. So all you need to do is extend Graphs.jl is to define in IGraphs.jl new methods for functions from Graphs.jl. No need for package extensions. |
Member
|
I will close this PR, but do not hesitate to open something similar in IGraphs.jl and then open a purely documentation-focused PR here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #446