fix: extract shared filterTemplates() to eliminate duplication (#118)#191
Merged
Conversation
Both popup.js and options.js contained identical filterTemplates() implementations differing only in CSS selector (.template-item vs .template-card). Extract to modules/ui-helpers.js as filterTemplateList() with a selector parameter; each consumer becomes a one-liner wrapper. Fixes #118
# Conflicts: # modules/ui-helpers.js # options/options.js # popup/popup.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterTemplates()function frompopup/popup.jsandoptions/options.jsinto a new shared modulemodules/ui-helpers.js.template-itemvs.template-card)filterTemplateList(selector)from the shared moduleChanges
modules/ui-helpers.js— exportsfilterTemplateList(itemSelector)popup/popup.js— imports and delegates tofilterTemplateList()options/options.js— imports and delegates tofilterTemplateList()Testing
Ran existing test suite (
npm test). The 7 pre-existing failures inmigrateV0toV1are unrelated to this change and present onmainbefore this fix. No new failures introduced.Fixes #118