Allow for quantile to operate over an entire Matrix#108
Allow for quantile to operate over an entire Matrix#108nalimilan merged 9 commits intoJuliaStats:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 96.91% 96.93% +0.01%
==========================================
Files 1 1
Lines 422 424 +2
==========================================
+ Hits 409 411 +2
Misses 13 13
Continue to review full report at Codecov.
|
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Not sure what a meaningful way to work out the quantiles of a matrix inplace would look like, so remove the ! to make it clear it isn't inplace
Previous method caused type ambiguity, this is okay.
|
Why did you remove the |
Added a method which accepts q when determining quantiles over a matrix. This q is modified in place. Added a test to confirm this behaviour
|
Sorry your question about the in-place test confused me. Anyways, I think I've implemented the changes you requested. |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 96.93%
=========================================
Files ? 1
Lines ? 424
Branches ? 0
=========================================
Hits ? 411
Misses ? 13
Partials ? 0 Continue to review full report at Codecov.
|
|
Thanks, and sorry for the delay! |
As discussed here if you pass a matrix to
quantileyou get an errorI made a small change which vectorises a matrix and provides the quantile for the whole matrix.
This change was originally made in StatsBase with PR 773.