Fix NaN and missing detection in quantile()#72
Merged
Conversation
When `sort=false`, we only partially sort the input, so `NaN`/`missing` is not guaranteed to be in the last position. Also avoid throwing errors for non-`Number` types, for which `isnan` may not be defined.
nalimilan
force-pushed
the
nl/nanquantile
branch
from
e09f2fd to
ca8369d
Compare
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage ? 83.11%
=========================================
Files ? 1
Lines ? 456
Branches ? 0
=========================================
Hits ? 379
Misses ? 77
Partials ? 0 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sort=false, we only partially sort the input, soNaN/missingis not guaranteed to be in the last position. Also avoid throwing errors for non-Numbertypes, for whichisnanmay not be defined.Partially supersedes https://github.com/JuliaLang/Statistics.jl/pull/54/. Relies on JuliaLang/julia#38232 to ensure that
isnanworks for any type (but before things were even worse).