Skip to content

Use Base.alloc_request instead of implementing it directly#1145

Merged
vtjnash merged 4 commits intomasterfrom
jn/alloc_request
Feb 13, 2026
Merged

Use Base.alloc_request instead of implementing it directly#1145
vtjnash merged 4 commits intomasterfrom
jn/alloc_request

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 14, 2024

There is slightly better error handling in this function, which avoids relying as directly on implementation details of IOBuffer

There is slightly better error handling in this function, which avoids relying as directly on implementation details of IOBuffer
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.67%. Comparing base (040cf0a) to head (90f3d79).
⚠️ Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   82.67%   82.67%   -0.01%     
==========================================
  Files          32       32              
  Lines        3054     3053       -1     
==========================================
- Hits         2525     2524       -1     
  Misses        529      529              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vtjnash vtjnash merged commit 0ac1528 into master Feb 13, 2026
@vtjnash vtjnash deleted the jn/alloc_request branch February 13, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants