Fix/accountsync/performance#82
Merged
Merged
Conversation
… for persistent streams Replace SendPage with OpenStream + SendPageOnStream so each dispatch worker owns one long-lived stream instead of opening a new connection per page.
Refactor the writeToWAL method in the AsyncBuffer to enhance error handling during buffer flushing. Introduce a variable to capture flush errors and log the last flushed LSN when successful. This update improves the clarity of log messages related to WAL operations and ensures better tracking of committed entries.
Add timing measurement for the WriteAccounts method to log the duration of the WAL enqueue operation. This improvement provides better insights into the performance of WAL operations by including the time taken to enqueue entries, aiding in performance monitoring and debugging.
Update the dispatchWorker method to open streams lazily on the first page or after a failure, ensuring that the first write follows the stream opening. This change improves stream negotiation handling and prevents premature stream resets, enhancing the reliability of account dispatching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.