Skip to content

KPMP-6570: rework maldi viewconfig settings#315

Merged
zwright merged 1 commit into
developfrom
KPMP-6570_maldi_config_settings
Mar 2, 2026
Merged

KPMP-6570: rework maldi viewconfig settings#315
zwright merged 1 commit into
developfrom
KPMP-6570_maldi_config_settings

Conversation

@HaneenT

@HaneenT HaneenT commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Style

    • Refined spatial imaging layer display settings with adjusted opacity and visibility configurations for improved visualization.
    • Updated image channel color and colormap settings.
  • Refactor

    • Enhanced internal data validation logic.

@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e213c6 and b695c97.

📒 Files selected for processing (2)
  • src/components/SpatialViewer/viewConfigHelper.js
  • src/helpers/dataHelper.js

Walkthrough

Updates spatial layer configurations for MAlDI multimodal setup, adjusting visibility and opacity values across AF, IMS, and PAS channels. Refactors object-emptiness checks in data helper functions using Object.keys() for more reliable validation.

Changes

Cohort / File(s) Summary
Spatial Layer Configuration
src/components/SpatialViewer/viewConfigHelper.js
Updates spatial layer visibility, opacity, and color settings for AF, IMS, and PAS channels in MAlDI multimodal configuration. Adds colormap for IMS and simplifies imageChannel array by removing spatialChannelWindow entries.
Data Validation Refactoring
src/helpers/dataHelper.js
Replaces object emptiness checks (data === {}) with Object.keys(data).length === 0 in mapSummaryKeysToPresentationStyle and mapClinicalKeysToPresentationStyle functions for more reliable validation.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch KPMP-6570_maldi_config_settings

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zwright zwright merged commit ddf1b6c into develop Mar 2, 2026
1 check passed
@zwright zwright deleted the KPMP-6570_maldi_config_settings branch March 2, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants