Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-gradle-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
jobs:
build-gradle-project:
env:
IMAGE_TAG: 3.2.0
IMAGE_TAG: 3.3.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Line 9 introduces a build/push tag mismatch that can break develop pushes.

IMAGE_TAG is now 3.3.0, but build.gradle is still version = '3.2.0' (Context snippet: build.gradle:15-16), and your Gradle docker task tags from project.version on develop (Context snippet: build.gradle:78-88).
Result: workflow may try to push kingstonduo/pegasus-data:3.3.0 even though only :3.2.0 was built.

Suggested fix
# Option A: keep versions aligned immediately
-      IMAGE_TAG: 3.3.0
+      IMAGE_TAG: 3.2.0
# Option B (preferred): single source of truth
# bump build.gradle to 3.3.0 in same PR, or compute IMAGE_TAG from Gradle project.version before push
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
IMAGE_TAG: 3.3.0
IMAGE_TAG: 3.2.0

runs-on: ubuntu-latest
steps:
- name: Get branch names
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ plugins {
}

group = 'kingstonduo'
version = '3.2.0'
version = '3.3.0'

apply plugin: 'java'
apply plugin: 'eclipse'
Expand Down
Loading