Skip to content

KPMP 6716 fix rp results#214

Merged
zwright merged 3 commits into
developfrom
KPMP-6716_fix-rp-results
Jun 8, 2026
Merged

KPMP 6716 fix rp results#214
zwright merged 3 commits into
developfrom
KPMP-6716_fix-rp-results

Conversation

@Dert1129

@Dert1129 Dert1129 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Updated cluster hierarchy data to include regional transcriptomics and regional proteomics indicators in place of spatial transcriptomics information, providing more granular classification of available data types for each cluster.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 650f85c0-2855-43a9-87f7-e0251621464e

📥 Commits

Reviewing files that changed from the base of the PR and between e907e21 and b59bde9.

📒 Files selected for processing (3)
  • src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchy.java
  • src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchyService.java
  • src/main/resources/graphql/knowledge_environment.graphqls
💤 Files with no reviewable changes (3)
  • src/main/resources/graphql/knowledge_environment.graphqls
  • src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchy.java
  • src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchyService.java

Walkthrough

The PR removes the isSpatialTranscriptomics transient property from the ClusterHierarchy entity model and its getter/setter methods. The ClusterHierarchyService replaces a bogusST placeholder with actual regional transcriptomics and proteomics configuration on the Tubulo-interstitium cluster, and the GraphQL schema is updated to expose isRegionalTranscriptomics and isRegionalProteomics fields instead.

Changes

Spatial to regional transcriptomics refactoring

Layer / File(s) Summary
ClusterHierarchy entity property removal
src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchy.java
Removes the @Transient isSpatialTranscriptomics field, its @JsonProperty-annotated getter and setter methods, and the corresponding imports for jakarta.persistence.Transient and com.fasterxml.jackson.annotation.JsonProperty.
Service logic and GraphQL schema alignment
src/main/java/org/kpmp/cellTypeSummary/ClusterHierarchyService.java, src/main/resources/graphql/knowledge_environment.graphqls
Replaces the bogusST placeholder (previously used to signal spatial transcriptomics with cellTypeOrder of -1.0) with proper regional transcriptomics and proteomics flag configuration on the tiCluster for Tubules and Interstitium, sets cellTypeOrder to 0.01, and updates the GraphQL schema to expose isRegionalTranscriptomics and isRegionalProteomics fields.

Possibly related PRs

  • KPMP/pegasus-data#203: Adds the isSpatialTranscriptomics transient property and bogusST placeholder logic that this PR removes and replaces with regional transcriptomics/proteomics fields.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch KPMP-6716_fix-rp-results

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zwright zwright merged commit b6eb73d into develop Jun 8, 2026
1 check passed
@zwright zwright deleted the KPMP-6716_fix-rp-results branch June 8, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants