Skip to content

added padding to the citation#646

Merged
HaneenT merged 4 commits into
developfrom
KPMP-6713_fix-citation
Jun 5, 2026
Merged

added padding to the citation#646
HaneenT merged 4 commits into
developfrom
KPMP-6713_fix-citation

Conversation

@Dert1129

@Dert1129 Dert1129 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • UI Improvements
    • Schematic attribution text is now displayed with improved spacing and layout formatting for better readability.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Two Explorer components are updated to improve the visual layout and text consistency of schematic attribution. The attribution text is now wrapped in a padded grid row/column structure, and both components prepend "Schematics courtesy of" to the attribution source text.

Changes

Schematic Attribution Layout and Text Updates

Layer / File(s) Summary
AccordionTabSection attribution layout and text
src/components/Explorer/AccordionTabSection.js
Nephron schematic attribution is wrapped in a Row with padding: "1rem" and placed in a Col. The attribution text is updated to include "Schematics courtesy of" prefix.
TabSection attribution layout and text
src/components/Explorer/TabSection.js
Main TabSection schematic attribution is wrapped in a Row with padding: "1rem" and placed in a Col below the primary content row, improving spacing and consistency.

Possibly Related PRs

  • KPMP/pegasus-web#624: Modifies the same Explorer components using Row/Col grid structure for layout adjustments.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch KPMP-6713_fix-citation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
src/components/Explorer/TabSection.js (1)

96-100: 🛠️ Refactor suggestion | 🟠 Major

Duplicated attribution block.

This attribution block is identical to the one in AccordionTabSection.js (lines 132-136). Please see the refactoring suggestion in that file to extract this into a shared component.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a237b1d0-4110-4c12-90aa-738e29853f4c

📥 Commits

Reviewing files that changed from the base of the PR and between bcc463e and e9c9704.

📒 Files selected for processing (2)
  • src/components/Explorer/AccordionTabSection.js
  • src/components/Explorer/TabSection.js

Comment on lines +132 to +136
<Row style={{padding: "1rem"}}>
<Col>
<small>Schematics courtesy of Bajema, Rachel, Supriya Bidanta, Ellen M. Quardokus, Bruce W. Herr II, and Katy Börner. December 2025. https://humanatlas.io/2d-ftu-illustrations, Accessed on June 1, 2026.</small>
</Col>
</Row>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Extract duplicated attribution block into a shared component.

The attribution layout and text are identical in both AccordionTabSection.js (lines 132-136) and TabSection.js (lines 96-100). This violates the DRY principle and creates a maintenance burden—any future changes to the citation or layout will require updates in multiple locations.

♻️ Suggested refactor: create a shared component

Create a new shared component SchematicAttribution.js:

import React from 'react';
import { Row, Col } from 'reactstrap';

const SchematicAttribution = () => {
  return (
    <Row style={{ padding: "1rem" }}>
      <Col>
        <small>
          Schematics courtesy of Bajema, Rachel, Supriya Bidanta, Ellen M. Quardokus, 
          Bruce W. Herr II, and Katy Börner. December 2025. 
          https://humanatlas.io/2d-ftu-illustrations, Accessed on June 1, 2026.
        </small>
      </Col>
    </Row>
  );
};

export default SchematicAttribution;

Then import and use it in both files:

+import SchematicAttribution from './SchematicAttribution';
-                <Row style={{padding: "1rem"}}>
-                    <Col>
-                        <small>Schematics courtesy of Bajema, Rachel, Supriya Bidanta, Ellen M. Quardokus, Bruce W. Herr II, and Katy Börner. December 2025. https://humanatlas.io/2d-ftu-illustrations, Accessed on June 1, 2026.</small>
-                    </Col>
-                </Row>
+                <SchematicAttribution />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Row style={{padding: "1rem"}}>
<Col>
<small>Schematics courtesy of Bajema, Rachel, Supriya Bidanta, Ellen M. Quardokus, Bruce W. Herr II, and Katy Börner. December 2025. https://humanatlas.io/2d-ftu-illustrations, Accessed on June 1, 2026.</small>
</Col>
</Row>
<SchematicAttribution />

@HaneenT HaneenT merged commit 34c9515 into develop Jun 5, 2026
1 check passed
@HaneenT HaneenT deleted the KPMP-6713_fix-citation branch June 5, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants