Conversation
Matched FBX entries by name/hash first, then paired remaining same-name files as changes so unchanged duplicates stop surfacing as noisy add/delete output. Extracted the diff logic into a focused module and added regression coverage for duplicate basename scenarios. Constraint: FBX-only tracking stores hashes by path but user-facing diffs need stable name-level change reporting Rejected: Keep basename-only add/delete labeling with index suffixes | still obscures real content changes Confidence: high Scope-risk: narrow Reversibility: clean Directive: If path-sensitive semantics are needed later, adjust calculate_fbx_diff instead of reintroducing basename-only display labels Tested: python3 -m unittest discover -s tests -p 'test_*.py'; python3 -m py_compile booth_checker/__main__.py booth_checker/fbx_diff.py tests/test_fbx_diff.py Not-tested: End-to-end BOOTH download flow and Discord changelog rendering with real FBX archives
…ushes Recent workflow changes switched GHCR login from the ephemeral repository `GITHUB_TOKEN` to a custom `GH_TOKEN` secret. That made registry login depend on an extra secret and token policy outside the repository defaults, and the build started failing during `docker/login-action` with `denied: denied`. This change returns both image publishing workflows to the built-in token path, which matches GitHub's recommended GHCR setup for packages associated with the workflow repository. Constraint: GHCR publishing must work without a separately managed PAT when repository-scoped workflow auth is sufficient Rejected: Keep `GH_TOKEN` and document secret setup | preserves a brittle dependency and does not address the observed login denial Confidence: high Scope-risk: narrow Reversibility: clean Directive: If GHCR push still fails, inspect package linkage and "Manage Actions access" on the existing package before reintroducing a PAT Tested: YAML parse for `.github/workflows/develop-build.yml` and `.github/workflows/latest-build.yml` Not-tested: End-to-end GitHub Actions run against GHCR from the hosted runner
Member
Author
|
PR 리뷰 누락 develop으로 계속 사용 시 문제 없어서 PR 진행 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
아이템 등록 및 업데이트 감지가 제대로 되지 않는 문제 수정