vcpkg: link Windows SDK system libs (bcrypt, ws2_32)#209
Merged
Conversation
The vcpkg crate emits link directives for the port's libraries and port dependencies, but not for Windows SDK system libraries (Libs.private in libxml-2.0.pc). libxml2 >= 2.12 calls BCryptGenRandom from xmlInitRandom (dict.c), leaving an unresolved external when linking the static libxml2.lib into a proc-macro/bin/test target; ws2_32 likewise backs nanohttp. Both import libs ship with every MSVC toolchain. Witnessed in latexml-oxide's Windows port: LNK2019 BCryptGenRandom in latexml_codegen's proc-macro dylib link. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vcpkg arm emits link directives for the port's libraries and port dependencies, but not for Windows SDK system libraries (
Libs.privateinlibxml-2.0.pc). libxml2 >= 2.12 callsBCryptGenRandomfromxmlInitRandom, so linking the staticlibxml2.libinto any real target (proc-macro dylib, bin, test) fails with LNK2019;ws2_32likewise backs nanohttp. Both import libraries ship with every MSVC toolchain, so linking them unconditionally in the vcpkg arm is safe.Witnessed in latexml-oxide's Windows port (first surfaced in a proc-macro dylib link, since
cargo checkof rlibs never links).