Skip to content

#338 remove paging runtime dependency#340

Merged
Kaaveh merged 1 commit into
kmpfrom
338-kmp-pagination
May 7, 2026
Merged

#338 remove paging runtime dependency#340
Kaaveh merged 1 commit into
kmpfrom
338-kmp-pagination

Conversation

@Kaaveh
Copy link
Copy Markdown
Owner

@Kaaveh Kaaveh commented May 7, 2026

Fix #338

@Kaaveh Kaaveh self-assigned this May 7, 2026
@Kaaveh Kaaveh added the kmp label May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Messages
📖 Thanks @Kaaveh!
📖 🎉 Code Cleanup!

Generated by 🚫 Danger Kotlin against 1fa86bb

@Kaaveh
Copy link
Copy Markdown
Owner Author

Kaaveh commented May 7, 2026

@claude

@claude
Copy link
Copy Markdown

claude Bot commented May 7, 2026

Claude finished @Kaaveh's task in 40s —— View job


PR Review

  • Gather context and read changed files
  • Analyze the dependency removal
  • Post review feedback

Summary

This is a clean, minimal cleanup that removes explicit paging-runtime dependencies from app-watch/ui and feature/marketlist, and removes the entry from the version catalog.

Analysis

Why this removal is safe:

androidx.paging:paging-compose already transitively pulls in paging-runtime, so declaring it explicitly was redundant. The dependency graph remains unchanged at runtime.

Why this is the right call for KMP migration:

  • paging-runtime is Android-only
  • paging-common (the KMP-compatible artifact) is already exposed via api() in domain/market/build.gradle.kts
  • Removing explicit Android-specific transitive deps is a good hygiene step for KMP migration

No remaining references:

paging-runtime is now fully absent from the build scripts and version catalog — no dangling aliases or usages.

Verdict

LGTM — correct, focused, and aligned with the KMP migration goals. No issues found.

@Kaaveh Kaaveh merged commit ad92c07 into kmp May 7, 2026
3 checks passed
@Kaaveh Kaaveh deleted the 338-kmp-pagination branch May 7, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Swap paging-runtime to paging-common multiplatform artifact

1 participant