Skip to content

#339 remove Koin android artifact #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaaveh merged 1 commit into from
May 7, 2026
Merged

#339 remove Koin android artifact #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/market-repository/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ dependencies {
implementation(libs.kermit)

// Koin
implementation(libs.koin.android)
implementation(libs.koin.core)

// Test
androidTestImplementation(kotlin("test"))
Expand Down
2 changes: 1 addition & 1 deletion domain/market/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ kotlin {

dependencies {
// Koin
implementation(libs.koin.android)
implementation(libs.koin.core)

// Test
androidTestImplementation(kotlin("test"))
Expand Down
6 changes: 4 additions & 2 deletions feature/marketdetail/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ configurations.all {

dependencies {
// Koin
implementation(libs.koin.android)
implementation(libs.koin.androidx.compose)
implementation(libs.koin.core)
implementation(libs.koin.compose)
implementation(libs.koin.compose.viewmodel)
implementation(libs.koin.core.viewmodel)

// Compose BOM
implementation(platform(libs.compose.bom))
Expand Down
2 changes: 1 addition & 1 deletion feature/marketdetail/src/main/java/ir/composenews/marketdetail/MarketDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.tooling.preview.PreviewParameter
import androidx.compose.ui.unit.dp
import org.koin.androidx.compose.koinViewModel
import org.koin.compose.viewmodel.koinViewModel
import coil.compose.rememberAsyncImagePainter
import ir.composenews.base.LoadableComponent
import ir.composenews.designsystem.component.LocalAnimatedVisibilityScope
Expand Down
2 changes: 1 addition & 1 deletion feature/marketdetail/src/main/java/ir/composenews/marketdetail/di/MarketDetailModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package ir.composenews.marketdetail.di

import ir.composenews.marketdetail.MarketDetailViewModel
import org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.core.module.dsl.viewModel
import org.koin.dsl.module

val marketDetailModule =
Expand Down
6 changes: 4 additions & 2 deletions feature/marketlist/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ configurations.all {

dependencies {
// Koin
implementation(libs.koin.android)
implementation(libs.koin.androidx.compose)
implementation(libs.koin.core)
implementation(libs.koin.compose)
implementation(libs.koin.compose.viewmodel)
implementation(libs.koin.core.viewmodel)

// Compose BOM
implementation(platform(libs.compose.bom))
Expand Down
2 changes: 1 addition & 1 deletion feature/marketlist/src/main/java/ir/composenews/marketlist/MarketListScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.PreviewParameter
import androidx.compose.ui.unit.dp
import org.koin.androidx.compose.koinViewModel
import org.koin.compose.viewmodel.koinViewModel
import androidx.paging.LoadState
import androidx.paging.compose.collectAsLazyPagingItems
import androidx.paging.compose.itemKey
Expand Down
2 changes: 1 addition & 1 deletion feature/marketlist/src/main/java/ir/composenews/marketlist/di/MarketListModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package ir.composenews.marketlist.di

import ir.composenews.marketlist.MarketListViewModel
import org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.core.module.dsl.viewModel
import org.koin.dsl.module

val marketListModule =
Expand Down
3 changes: 3 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ kermit = { group = "co.touchlab", name = "kermit", version.ref = "kermit" }
koin-core = { group = "io.insert-koin", name = "koin-core", version.ref = "koin" }
koin-android = { group = "io.insert-koin", name = "koin-android", version.ref = "koin" }
koin-androidx-compose = { group = "io.insert-koin", name = "koin-androidx-compose", version.ref = "koin" }
koin-compose = { group = "io.insert-koin", name = "koin-compose", version.ref = "koin" }
koin-compose-viewmodel = { group = "io.insert-koin", name = "koin-compose-viewmodel", version.ref = "koin" }
koin-core-viewmodel = { group = "io.insert-koin", name = "koin-core-viewmodel", version.ref = "koin" }
koin-workmanager = { group = "io.insert-koin", name = "koin-androidx-workmanager", version.ref = "koin" }

lifecycle-runtime-ktx = { group = "androidx.lifecycle", name = "lifecycle-runtime-ktx", version.ref = "lifeCycle" }
Expand Down
Loading