Skip to content

Allow using nette/utils ^4.0#84

Open
hubipe wants to merge 5 commits into
Kdyby:masterfrom
hubipe:master
Open

Allow using nette/utils ^4.0#84
hubipe wants to merge 5 commits into
Kdyby:masterfrom
hubipe:master

Conversation

@hubipe
Copy link
Copy Markdown

@hubipe hubipe commented Apr 20, 2023

This library require nette/utils ^3.0, which effectively prevent updating Nette on our project to 4.0.
I've created pull request, which only modifies composer.json to allow nette/utils ^4.0 as this library does not use any of the methods listed in BC breaks on nette/utils 4.0.

Please once you merge it, release a new version. Thank you

@thorewi
Copy link
Copy Markdown

thorewi commented Aug 7, 2023

@hubipe except of chaning to 4.0 i can see also:

public function stopConsuming(): void
	{
		foreach ($this->queues as $name => $options) {
			$this->getChannel()->basic_cancel($this->getQueueConsumerTag($name));
		}
		$this->onStop($this);
	}

which probably shouldn't be there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants