Open
Conversation
This commit introduces a more realistic battery charging simulation for electric fuel tanks. The new implementation includes: - A non-linear charging curve where the charge rate slows down as the battery approaches full capacity. - Battery wear, which reduces the maximum capacity of the battery with each charge cycle. - Heat generation during charging, which affects the charging speed. - Charging inefficiency, where a percentage of the energy is lost to heat. - New wire outputs and overlay text for heat and wear.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This commit fixes a syntax error in the E2 extension loader that was preventing some commands from loading correctly. The error was caused by having the `[nodiscard]` and `[deprecated]` attributes within the same set of brackets. By separating the attributes into their own brackets (e.g., `[nodiscard][deprecated="..."]`), the E2 extension can now parse them correctly.
This commit introduces a comprehensive overhaul of the battery and Explosive Reactive Armor (ERA) systems. **Battery System:** - Implemented a non-linear charging curve, where the charge rate decreases as the battery approaches full capacity. - Added battery wear, which reduces the maximum charge a battery can hold over time. - Incorporated heat generation during charging, which impacts charging speed. - Set charging efficiency to 90%, with 10% energy loss. - Corrected bugs related to `PristineCapacity` and `DeltaTime` calculations. - Enabled linking between generators and batteries for charging. - Updated the UI to display the new, detailed battery status. **ERA System:** - Defined three generations of ERA armor (Kontakt-1, Kontakt-5, Relikt) with distinct properties. - Implemented the `ACF_ERADetonate` function to handle the explosive reaction of the armor, reducing projectile penetration. - Introduced a chain reaction mechanic for ERA blocks. - The main damage function, `ACF_BulletHit`, now triggers the ERA detonation before calculating damage to the underlying armor. - Updated the armor tool to display detailed ERA-specific information, including performance against AP and HEAT rounds, and chain reaction chance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jules PR
PR created automatically by Jules for task 812534088662915793