Conversation
cvigilv
approved these changes
Mar 24, 2026
Collaborator
cvigilv
left a comment
There was a problem hiding this comment.
Looks good! I merged main into this branch as yesterday I pushed some changes to main. Lets wait for the CI to run and we can merge
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup done with Claude. Mainly typos and removing unused code
Code style issues
Typo "Represenetations" in FHRR comment and docstring(fixed)Missing blank line between TernaryHV and BinaryHV sections(fixed)TODO block references "complex HDC" which is now implemented (FHRR)(fixed)BinaryHV docstring says "A ternary hypervector type"(fixed)Stale comment about LazyArrays in(fixed)operations.jlTypo "Measurures" in(fixed)isapproxdocstringsTypo "N_bootstap" in(fixed)isapproxdocstring(deleted)predictors.jlcontains Dutch comments and dead codeUnused(fixed)countsvariable inrepresentations.jlshow methodUnused(fixed)countsvariable inext/UnicodePlotting.jlshow method(filled in)docs/src/index.mdplaceholder text "provides..."(fixed)docs/src/index.mdand README link to wrong repo owner(removed)introduction-to-hdc.jluses undeclaredHandcalcsdependencyTypos "constituyents" / "contituyent" in introduction tutorial(fixed)(deleted)scripts/concept.jluses entirely obsolete API(deleted)test/benchmarking.jluses entirely obsolete APITernaryHV docstring says elements in(fixed to(-1, 1)(open interval){-1, +1})Graph docstring uses(fixed)\otimesfor outer op instead of\oplusTypo "incoding" in(fixed)convertleveldocstring