Skip to content

BLOCKER: Sprint 42 Slice 5 needs persisted press history#34

Draft
KevinBigham wants to merge 1 commit into
mainfrom
sprint-42/slice-5-press-conference-history
Draft

BLOCKER: Sprint 42 Slice 5 needs persisted press history#34
KevinBigham wants to merge 1 commit into
mainfrom
sprint-42/slice-5-press-conference-history

Conversation

@KevinBigham
Copy link
Copy Markdown
Owner

Slice 5: Press Conference History

Branch: sprint-42/slice-5-press-conference-history
Engine: preflight only
SAVE_VERSION: unchanged at 35

What it does

BLOCKER: this slice stopped at the packet kill switch. The engine/save state does not expose a persisted pressConferenceHistory[] archive for a history ledger. It only persists recentPressConferences, which recordPressConference(...) caps to five entries.

Verification

  • Preflight search PASS — confirmed no pressConferenceHistory state/save field exists
  • SAVE_VERSION unchanged at 35
  • pnpm -r typecheck NOT RUN — no code changes
  • pnpm test NOT RUN — no code changes
  • pnpm --filter @mfd/web build NOT RUN — no code changes
  • check-bundle-size.sh NOT RUN — no code changes
  • check-math-random.sh NOT RUN — no code changes

Evidence

  • packages/engine/src/systems/press-conference.ts records into game.recentPressConferences = [conference, ...game.recentPressConferences].slice(0, 5)
  • packages/engine/src/types/franchise.ts exposes recentPressConferences: PressConference[]
  • packages/engine/src/save/schema.ts persists recentPressConferences
  • rg "pressConferenceHistory" packages/engine/src returned no archive field

Notes for Kevin

A real Press Conference History screen needs an engine/save-backed archive field or a design decision to intentionally surface only the recent five. I did not fabricate history from transient modal state.

Generated with Codex
Co-Authored-By: Codex noreply@openai.com

Stops at the packet kill switch because the engine persists only recentPressConferences, capped to five entries, and does not expose a pressConferenceHistory archive for a ledger view.

Co-Authored-By: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant