Skip to content

Sprint 46: Add achievements gallery#51

Merged
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-2-achievements-gallery
Apr 30, 2026
Merged

Sprint 46: Add achievements gallery#51
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-2-achievements-gallery

Conversation

@KevinBigham
Copy link
Copy Markdown
Owner

Summary

  • Adds a franchise achievements gallery route backed by the existing engine achievement catalog.
  • Adds medal SVG variants for bronze, silver, gold, and locked states using existing design tokens and lucide lock overlay.
  • Covers filtering, sorting-adjacent state, counter, locked empty state, medal rendering, and additive route registration with renderToStaticMarkup tests.

Save schema impact

None. SAVE_VERSION remains 35; no engine/save/migration/fixture files changed.

How to test

  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 -r typecheck
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 test
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 --filter @mfd/web build
  • bash scripts/check-bundle-size.sh
  • bash scripts/check-math-random.sh

Look for all commands to pass, index gzip below 181 KB, engine bundle gate unchanged at 257 KB, and no Math.random violations.

Risks / handoff for Claude Code

  • Category chips mirror the actual engine AchievementCategory values on origin/main: dynasty, roster, draft, financial, coaching, narrative, records, milestones, hidden.
  • Route registration is additive in App.tsx via a new lazy route and post-routeTree addChildren call.
  • No selector gap: selectAchievements already exists and is consumed directly.
  • No packages/engine changes.

@KevinBigham KevinBigham marked this pull request as ready for review April 30, 2026 18:35
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Surfaces the existing achievement catalog through a reviewable franchise route without changing engine or save state.
@KevinBigham KevinBigham force-pushed the sprint-46/slice-2-achievements-gallery branch from 9ca31c9 to 5d139a8 Compare April 30, 2026 19:07
@KevinBigham KevinBigham merged commit 6795c9f into main Apr 30, 2026
1 of 2 checks passed
@KevinBigham KevinBigham deleted the sprint-46/slice-2-achievements-gallery branch April 30, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant