Sprint 46: Polish coaching tree visuals#53
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61e585ee6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| key={`disciple-line-${entry.coachId}`} | ||
| data-coaching-tree-line="true" | ||
| data-line-kind="direct-disciple" | ||
| d={`M50 52 C60 ${44 + idx * 9} 68 ${37 + idx * 10} 78 ${31 + idx * 10}`} |
There was a problem hiding this comment.
Clamp disciple connector coordinates to the SVG viewport
The disciple path formula pushes Y coordinates beyond the viewBox height once there are many disciples (31 + idx * 10 exceeds 100 at idx >= 7), so later disciples lose their connector lines even though cards still render. This affects long-running saves where a head coach has 8+ disciples and makes the new relationship overlay incomplete for valid data.
Useful? React with 👍 / 👎.
Adds visual lineage signals to the existing coaching tree without changing engine data or save state.
61e585e to
e788052
Compare
Summary
Save schema impact
None. SAVE_VERSION remains 35; no engine/save/migration/fixture files changed.
How to test
Look for all commands to pass, index gzip below 181 KB, engine bundle gate unchanged at 257 KB, and no Math.random violations.
Risks / handoff for Claude Code