Skip to content

Sprint 46: Polish coaching tree visuals#53

Merged
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-4-coaching-tree-visual
Apr 30, 2026
Merged

Sprint 46: Polish coaching tree visuals#53
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-4-coaching-tree-visual

Conversation

@KevinBigham
Copy link
Copy Markdown
Owner

Summary

  • Adds six hand-crafted coaching archetype SVG glyphs and maps existing coach archetype strings into visual families.
  • Adds glyphs inside the existing CoachingTree coach cards while preserving the current card text and lineage rendering.
  • Adds a passive SVG connection overlay for mentor and disciple relationships with gold direct-mentor, dashed indirect, and cyan disciple lines.
  • Adds renderToStaticMarkup coverage for glyph variants, connection lines, relationship styling, and existing tree surface behavior.

Save schema impact

None. SAVE_VERSION remains 35; no engine/save/migration/fixture files changed.

How to test

  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 -r typecheck
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 test
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 --filter @mfd/web build
  • bash scripts/check-bundle-size.sh
  • bash scripts/check-math-random.sh

Look for all commands to pass, index gzip below 181 KB, engine bundle gate unchanged at 257 KB, and no Math.random violations.

Risks / handoff for Claude Code

  • First full pnpm test attempt timed out in long engine integration files under local worker load; the timed-out files passed in isolation, then the full pnpm test gate passed on rerun.
  • CoachingTree logic is preserved; the diff wraps the existing three-column layout only to add a passive SVG overlay.
  • No packages/engine changes.

@KevinBigham KevinBigham marked this pull request as ready for review April 30, 2026 18:35
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61e585ee6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

key={`disciple-line-${entry.coachId}`}
data-coaching-tree-line="true"
data-line-kind="direct-disciple"
d={`M50 52 C60 ${44 + idx * 9} 68 ${37 + idx * 10} 78 ${31 + idx * 10}`}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clamp disciple connector coordinates to the SVG viewport

The disciple path formula pushes Y coordinates beyond the viewBox height once there are many disciples (31 + idx * 10 exceeds 100 at idx >= 7), so later disciples lose their connector lines even though cards still render. This affects long-running saves where a head coach has 8+ disciples and makes the new relationship overlay incomplete for valid data.

Useful? React with 👍 / 👎.

Adds visual lineage signals to the existing coaching tree without changing engine data or save state.
@KevinBigham KevinBigham force-pushed the sprint-46/slice-4-coaching-tree-visual branch from 61e585e to e788052 Compare April 30, 2026 19:10
@KevinBigham KevinBigham merged commit f6c6b44 into main Apr 30, 2026
2 checks passed
@KevinBigham KevinBigham deleted the sprint-46/slice-4-coaching-tree-visual branch April 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant