Skip to content

Sprint 46: Polish standings signals#54

Merged
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-5-standings-visual
Apr 30, 2026
Merged

Sprint 46: Polish standings signals#54
KevinBigham merged 1 commit into
mainfrom
sprint-46/slice-5-standings-visual

Conversation

@KevinBigham
Copy link
Copy Markdown
Owner

Summary

  • Adds tokenized standings signal SVGs for hot/cold streaks, playoff seed state, and division leaders.
  • Threads the signals into the existing LeagueStandings table cells without changing selectors, sorting, or engine data.
  • Converts touched standings colors to --mfd-* tokens to keep Sprint 46 UI token discipline.

Save schema impact
None. SAVE_VERSION remains 35; packages/engine/** has 0 changed files.

How to test

  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 -r typecheck
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 test
  • NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@9.15.9 --filter @mfd/web build
  • bash scripts/check-bundle-size.sh
  • bash scripts/check-math-random.sh

Expected: typecheck/test/build pass; @mfd/web build index gzip is 172.67 KB; check-bundle-size reports engine gzip 257 KB; check-math-random passes.

Risks / handoff for Claude Code

  • Seed state uses existing playoffPicture data: top 3 or X/Y indicators render locked, seeds 4-7 render bubble, and non-seeded standings rows render out.
  • PixelTable does not expose row styling hooks, so the division-leader trim is applied inside the team cell wrapper while preserving row behavior.

@KevinBigham KevinBigham marked this pull request as ready for review April 30, 2026 18:35
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Adds visual standings signals to existing rows without changing engine data or save state.
@KevinBigham KevinBigham force-pushed the sprint-46/slice-5-standings-visual branch from a0ad1a8 to 482219b Compare April 30, 2026 19:11
@KevinBigham KevinBigham merged commit dc7740a into main Apr 30, 2026
2 checks passed
@KevinBigham KevinBigham deleted the sprint-46/slice-5-standings-visual branch April 30, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant