[SPIR-V] Start cleaning up register classes.#258
Open
zuban32 wants to merge 1 commit into
Open
Conversation
In order to fix EXPENSIVE_CHECKS failures the hierarchy of register classes for SPIRV target needs to be adjusted. This patch removes redundant FP regclasses since they effectively mimic type inference for existing generic FP instructions. Also this change begins replacing explicit setRegClass calls with simply constraining instruction operands.
michalpaszkowski
approved these changes
Apr 17, 2023
Member
michalpaszkowski
left a comment
michalpaszkowski
left a comment
There was a problem hiding this comment.
Looks like there are no regressions in the testing
Member
|
@zuban32 Do you think this patch could be pushed to Phabricator? |
Contributor
Author
Absolutely, I just need to split it into 2-3 smaller patches before uploading. Plan to do that in the next 1-2 weeks |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix EXPENSIVE_CHECKS failures the hierarchy of register classes for SPIRV target needs to be adjusted.
This patch removes redundant FP regclasses since they effectively mimic type inference for existing generic FP instructions.
Also this change begins replacing explicit setRegClass calls with simply constraining instruction operands.