Command-buffer queue compatibility test update#2230
Merged
Conversation
This was referenced Feb 5, 2025
bashbaug
reviewed
Feb 5, 2025
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
One additional note - I believe the negative_enqueue_queue_not_compatible test is invalid now, and can be removed.
EwanC
force-pushed
the
command_buffer_queue_refactor
branch
2 times, most recently
from
d293fcc to
9c663aa
Compare
Update cl_khr_command_buffer tests to reflect changes from KhronosGroup/OpenCL-Docs#1292 Required headers change KhronosGroup/OpenCL-Headers#271 to enable tests with version 0.9.7
EwanC
force-pushed
the
command_buffer_queue_refactor
branch
from
9c663aa to
5999c5a
Compare
bashbaug
previously approved these changes
Feb 6, 2025
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
The new tests LGTM.
I still think the negative_enqueue_queue_not_compatible test is invalid now, but would you prefer to remove it in a separate PR?
Test is no longer valid, and has been superseded by newly added tests
Contributor
Author
Apologies! I overlooked that bit of feedback. I agree, pushed a new commit to remove that test. |
bashbaug
approved these changes
Feb 7, 2025
Contributor
|
Merging as discussed in the February 11th teleconference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cl_khr_command_buffer tests to reflect changes from KhronosGroup/OpenCL-Docs#1292
CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHRfrom command-buffer creation to enqueue.CL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHRfrom command-buffer creation to enqueue.CL_INVALID_DEVICEon command-buffer enqueue for new error condition in spec. Although it requires a context to be contain more than 1 device, which I'm not sure if possible in current test framework.