Added floating point types support for work_group_reduce tests#2525
Merged
Conversation
bashbaug
reviewed
Sep 15, 2025
Contributor
bashbaug
previously approved these changes
May 14, 2026
Comment on lines
+211
to
+212
| static void generate_reference_values(Type *inptr, size_t n_elems, | ||
| size_t max_wg_size, Type &max_err = 0) |
Contributor
There was a problem hiding this comment.
Slight nitpick: This is generating input values (and the max error for those input values), not reference values. Might be best to rename this function to avoid confusion.
shajder
added a commit
to shajder/OpenCL-CTS
that referenced
this pull request
May 19, 2026
-adapted from KhronosGroup#2525 due to code review
shajder
added a commit
to shajder/OpenCL-CTS
that referenced
this pull request
May 19, 2026
-adapted from KhronosGroup#2525 due to code review
bashbaug
approved these changes
May 19, 2026
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Merging as discussed in the May 19th teleconference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1364