Add tests for cloned kernel via clCloneKernel#2577
Merged
neiltrevett merged 5 commits intoJun 2, 2026
Conversation
|
|
MichaelRizkalla-arm
force-pushed
the
add_cloned_kernel_tests
branch
from
0a4f73d to
fd39b71
Compare
EwanC
reviewed
Nov 13, 2025
MichaelRizkalla-arm
force-pushed
the
add_cloned_kernel_tests
branch
from
fd39b71 to
40b2e4b
Compare
Contributor
Author
|
Thanks for the review, I've addressed the comments. I've also incorporated the changes from #1251 as this PR is intended to continue that work. |
MichaelRizkalla-arm
force-pushed
the
add_cloned_kernel_tests
branch
from
40b2e4b to
72fb5b9
Compare
EwanC
previously approved these changes
Nov 14, 2025
Contributor
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
I haven't had a chance to run this code, but LGTM with some minor comments
bashbaug
requested changes
Nov 19, 2025
Contributor
|
Removing "focused review" until the comments above are addressed. |
Use `clSetKernelArg` to set args after kernel is cloned. Enqueue and read the buffer to validate. The test uses `buf_write_kernel` kernel program with 2 arguments. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com> Co-authored-by: Vikas Katariya <vikas.katariya@arm.com> Co-authored-by: Ahmed Hesham <ahmed.hesham@arm.com>
Add equality operators to `clSVMWrapper` to compare with `clSVMWrapper` object or a `nullptr`. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com>
Use `clSetKernelExecInfo` after kernel is cloned and read the buffer to validate. The test uses the `set_kernel_exec_info_kernel` kernel program with 2 arguments. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com> Co-authored-by: Vikas Katariya <vikas.katariya@arm.com> Co-authored-by: Ahmed Hesham <ahmed.hesham@arm.com>
Clone a kernel with no args and enqueue. The test uses `test_kernel_empty` kernel program with no arguments. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com> Co-authored-by: Vikas Katariya <vikas.katariya@arm.com> Co-authored-by: Ahmed Hesham <ahmed.hesham@arm.com>
Use `clSetKernelArgSVMPointer` to set args after kernel is cloned. Enqueue and read the buffer to validate. The test uses `buf_write_kernel` kernel program with 2 arguments. Signed-off-by: Michael Rizkalla <michael.rizkalla@arm.com> Co-authored-by: Vikas Katariya <vikas.katariya@arm.com> Co-authored-by: Ahmed Hesham <ahmed.hesham@arm.com>
MichaelRizkalla-arm
force-pushed
the
add_cloned_kernel_tests
branch
from
72fb5b9 to
4d9ca3a
Compare
bashbaug
approved these changes
May 20, 2026
Contributor
|
Latest version LGTM - thanks! @lakshmih is this one you'd like to review? |
Contributor
|
Discussed in the May 26th teleconference. OK to merge offline with one additional review (@lakshmih). |
lakshmih
approved these changes
Jun 2, 2026
Collaborator
|
This commit broke some tests when running with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.