Skip to content

Fix error handling logic in test_kernel_call_kernel_function#2714

Open
joselopeqti wants to merge 2 commits into
KhronosGroup:mainfrom
joselopeqti:fix_kernel_call_kernel_error_handling
Open

Fix error handling logic in test_kernel_call_kernel_function#2714
joselopeqti wants to merge 2 commits into
KhronosGroup:mainfrom
joselopeqti:fix_kernel_call_kernel_error_handling

Conversation

@joselopeqti
Copy link
Copy Markdown
Collaborator

Fixes the following issues:

  1. Incorrect suppression condition in sections 2 & 3
    Both sections use if (errors > 10) twice instead of having a trigger condition (errors == 10). As a result, the "Suppressing further results..." message never prints, and errors are skipped silently.

  2. Incorrect pass reporting in section 3
    Since errors are global, earlier sub-tests may already push it beyond 10. Section 3 then immediately skips error handling (due to errors > 10), including setting pass = 0, and incorrectly reports "Passed" even when errors occur.

  3. Repeated suppression message in section 1
    When errors == 10, the code prints the suppression message and continues without incrementing errors. This causes the condition to remain true, printing the message repeatedly for every subsequent error instead of just once, while doing nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants