Fix error handling logic in test_kernel_call_kernel_function#2714
Open
joselopeqti wants to merge 2 commits into
Open
Fix error handling logic in test_kernel_call_kernel_function#2714joselopeqti wants to merge 2 commits into
joselopeqti wants to merge 2 commits into
Conversation
rjodinchr
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
Incorrect suppression condition in sections 2 & 3
Both sections use if (errors > 10) twice instead of having a trigger condition (errors == 10). As a result, the "Suppressing further results..." message never prints, and errors are skipped silently.
Incorrect pass reporting in section 3
Since errors are global, earlier sub-tests may already push it beyond 10. Section 3 then immediately skips error handling (due to errors > 10), including setting pass = 0, and incorrectly reports "Passed" even when errors occur.
Repeated suppression message in section 1
When errors == 10, the code prints the suppression message and continues without incrementing errors. This causes the condition to remain true, printing the message repeatedly for every subsequent error instead of just once, while doing nothing else.