Skip to content

Clear clReImportSemaphoreSyncKhr semantics for use after signal/wait #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joselopeqti wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clear clReImportSemaphoreSyncKhr semantics for use after signal/wait #1454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb39d54
Clear clReImportSemaphoreSyncKhr semantics
joselopeqti Sep 9, 2025
fe1a1c8
Reword reimport condition
joselopeqti Sep 11, 2025
41f0824
Update api/opencl_runtime_layer.asciidoc
joselopeqti Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/opencl_runtime_layer.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13842,6 +13842,8 @@ _sema_object_ and re-creating it with the original _sema_props_ from
be imported.
The semaphore _sema_object_ must have originally imported an external handle
of type {CL_SEMAPHORE_HANDLE_SYNC_FD_KHR}.
Calling {clReImportSemaphoreSyncFdKHR} when the last operation performed on
Copy link
Copy Markdown
Contributor

@kpet kpet Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025/09/16 memory TSG teleconference: do we need a more precise definition of what constitutes performing an operation? Is a query an operation? Does "perform[ing]" mean executing a command or enqueuing a command? This needs to be clarified.

Copy link
Copy Markdown
Contributor Author

@joselopeqti joselopeqti Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context "perform" covers both enqueue and execution. We are open to proposals that would help to clarify the meaning of the text.

Copy link
Copy Markdown
Contributor

@bashbaug bashbaug Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to refer to the queried value for CL_SEMAPHORE_PAYLOAD_KHR here? This isn't sufficient to cover cases where the semaphore has pending signals or waits enqueued, so perhaps additional text is still required, but if the (binary) semaphore payload is zero to indicate that it is in the un-signaled state then I think it is a more precise way of saying "the last operation performed on sema_object was a wait".

Copy link
Copy Markdown
Contributor Author

@joselopeqti joselopeqti Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We believe that referring to the queried value might not be enough due to possible pending signals and waits. We are leaning towards a condition like:
"The last enqueued command to reference the semaphore should be clEnqueueWaitSemaphoresKHR and the semaphore should be in the un-signaled state."

_sema_object_ was not a wait will result in undefined behavior.

// refError

Expand Down