Add ProtoSYCL to the CTS#1200
Conversation
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
This reverts commit c80df22. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
| set(CMAKE_CXX_STANDARD 20) | ||
| elseif(SYCL_IMPLEMENTATION STREQUAL ProtoSYCL) | ||
| set(CMAKE_CXX_STANDARD 23) |
There was a problem hiding this comment.
I suggest moving this to cmake/FindProtoSYCL.cmake to isolate implementation specific settings similar to cmake/FindDPCPP.cmake.
| - sycl-impl: simsycl | ||
| version: 960c155109b066b26c1ecb6b2348ff9f6b69704d | ||
| - sycl-impl: protosycl | ||
| version: main |
There was a problem hiding this comment.
Why the branch name instead of SHA? I think we want reliable CI results.
|
(Ok I cannot add you to CTS-reviewer, I think @bader can do it, so you start a branch and build the docker image on the CI) |
|
I can only give write access to the repository to an individual account. We usually manage access via GitHub teams. Write access have two teams, but only team maintainers can add new members:
|
I removed Tom Deakin from sycl-committe. I assume he should also be removed from sycl-cts-reviewers, and we should make someone else a maintainer. @bader should you be the maintainer there? I forget how to make someone a GH teams maintainer. Maybe we need to ask Khronos webservices to do this? Regarding adding @0x12CC to sycl-committee ... I can do this only after he is added to the Khronos organization. I asked him offline to do this. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
|
I created #1201 without using my fork. Closing this PR. |
4 participants
This PR adds support for running CTS tests with ProtoSYCL.