Clarify optional kernel features.#1010
Merged
gmlueck merged 3 commits intoMay 21, 2026
Merged
Conversation
gmlueck
approved these changes
May 14, 2026
Contributor
|
One more reviewer and waiting from Hugh |
hdelan
approved these changes
May 15, 2026
| implementation supports the features on any of its devices. | ||
| For the two C++ attributes listed above, all implementations must be able to | ||
| compile kernels that are decorated with these attributes regardless of whether | ||
| the implementation supports the specified work-group or sub-group size. |
There was a problem hiding this comment.
Slight nit:
Suggested change
| the implementation supports the specified work-group or sub-group size. | |
| a device supports the specified work-group or sub-group size. |
Contributor
There was a problem hiding this comment.
Either way is OK with me. The previous sentence say:
... regardless of whether the implementation supports the features on any of its devices.
we could use that same language here:
... regardless of whether the implementation supports the specified work-group or sub-group size on any of its devices.
Contributor
Author
There was a problem hiding this comment.
I made those changes, please verify.
gmlueck
reviewed
May 19, 2026
gmlueck
approved these changes
May 19, 2026
TApplencourt
approved these changes
May 19, 2026
Contributor
|
Amazing! Thanks a lot |
Contributor
|
WG: Agree to merge as clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.