Harden Apps Script forwarder validation#151
Draft
poulcarlsen53 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This tightens the Apps Script relay script without changing the tunnel protocol.
It rejects obvious non-tunnel POST bodies before spending
UrlFetchAppquota, expands the relay loop guard to coverscript.googleusercontent.comvariants, and exposes a little more safe deployment metadata fromdoGet.Why
A mispointed
RELAY_URLSvalue or public probe can waste daily Apps Script quota and produce confusing non-batch responses in the client. This keeps the script as a simple encrypted forwarder, but makes the edges safer and easier to diagnose.Notes
I intentionally did not add a custom
UrlFetchApp.fetchtimeout option here because Apps Script does not document a supported per-request timeout parameter forUrlFetchApp. The script still usesfollowRedirects: falseandmuteHttpExceptions: true, and still throws when every upstream fails so clients treat that as an endpoint failure instead of trying to decode an error string.Validation
go test -count=1 ./apps_script ./internal/carriergo test -count=1 ./...