Skip to content

feat(gastown): integrate gastown into dev:env secret management#4014

Open
IamCoder18 wants to merge 1 commit into
Kilo-Org:mainfrom
IamCoder18:feat/gastown-dev-env-integration
Open

feat(gastown): integrate gastown into dev:env secret management#4014
IamCoder18 wants to merge 1 commit into
Kilo-Org:mainfrom
IamCoder18:feat/gastown-dev-env-integration

Conversation

@IamCoder18

Copy link
Copy Markdown
Contributor

Summary

Creates services/gastown/.dev.vars.example with @from annotations for NEXTAUTH_SECRET and GASTOWN_JWT_SECRET, enabling the dev:env sync system to generate .dev.vars and auto-create Secrets Store entries for Gastown locally.

Closes #4013

Previously Gastown hardcoded dev secrets in wrangler.jsonc env.dev.vars, which drifted from .env.local and couldn't benefit from the centralized secret management pipeline. The committed wrangler.jsonc already has correct secrets_store_secrets bindings in both top-level (production) and env.dev (local) sections, so no wrangler config changes are needed.

Verification

  • Run pnpm dev:env and verify Gastown secrets are generated.

Visual Changes

N/A

Reviewer Notes

  • The only file change is the new .dev.vars.example. The wrangler.jsonc already had correct secrets_store_secrets bindings in env.dev from a prior commit.
  • GASTOWN_JWT_SECRET must be added to .env.local; otherwise the placeholder value from .dev.vars.example is used.
  • Production deployment is completely unaffected. wrangler deploy uses top-level secrets_store_secrets bindings which are unchanged.

Create .dev.vars.example with @from annotations for NEXTAUTH_SECRET
and GASTOWN_JWT_SECRET, enabling the dev:env sync system to generate
.dev.vars and auto-create Secrets Store entries for gastown locally.

Previously gastown hardcoded dev secrets in wrangler.jsonc env.dev.vars,
which drifted from .env.local and couldn't benefit from the centralized
secret management pipeline.
@kilo-code-bot

kilo-code-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Single-file addition of services/gastown/.dev.vars.example is correct, consistent with repo conventions, and the @from annotations correctly wire into the existing dev:env secret management pipeline.

Files Reviewed (1 file)
  • services/gastown/.dev.vars.example

Reviewed by claude-4.6-sonnet-20260217 · 859,000 tokens

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gastown secrets not managed by dev:env

1 participant