GPU device selection#7
Open
Mark-Shun wants to merge 2 commits into
Open
Conversation
Author
|
Can I do anything on my end to make this PR acceptable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
As mentioned in the Discord server, a friend of mine ran into the problem that the wrong GPU device (integrated graphics card on presumably the CPU) was being used instead of the dedicated video card (0,5GB VRAM vs 6.0GB VRAM). Due to this inference/processing was extremely slow. Looking at the code base it seems like it automatically hardcoded selects the first available device.
Goal of this change
The goal of this PR was to create and intergrade a GPU device selection functionality into the settings, so that an user can manually adjust it if needed.
Having tested it with the user encountering the problem, it now works.
As can be seen in the screenshot, Vapourkit now uses the NVIDIA GPU instead of the AMD Radeon iGPU

The functionality is exposed in the settings panel in the inference backend.

Changes
Disclaimer: AI has been utilized to implement these changes
Backend
The NPM package systeminformation has been added and is being utilised to retrieve the available graphics devices.
Frontend
Backwards compatibility:
Defaults to device_id=0 when no preference is saved. All existing IPC signatures maintain backward compatibility via optional deviceId parameters.