Add foreign key constraint to project logo ID #3322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
project-logo-foreign-key-constraint
branch
from
3da6d9f to
b23aa8f
Compare
josephsnyder
reviewed
Jan 5, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Mostly looks good. I do get a 404 in the network tab when attempting the decache, which I think leads to the "Current Logo" not updating properly when the image is changed:
Collaborator
Author
|
@josephsnyder I also see that error on master. The image gets uploaded properly (as seen by reloading the page), so it's just the response that isn't handled correctly. I'll create a separate PR with the fix. |
josephsnyder
approved these changes
Jan 5, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project
imageidcolumn was passed over in previous PRs introducing foreign-key constraints because the column used the value 0 to indicate a special case. This PR switches that logic to use null to represent the missing logo case, thus allowing us to add a proper foreign key constraint.