Clean up and fix redundant/missing checks in OKT, S3M, ULT loaders. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OKT: numerous alignment/big endian fixes. * OKT: add missing chunk size bounds checks. * OKT: remove redundant chunk bounds checks added by fuzz-patch-1. * S3M: remove duplicate channel panning table check. * ULT: remove duplicate event bounds check.
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jan 28, 2022
* OKT: numerous alignment/big endian fixes. * OKT: add missing chunk size bounds checks. * OKT: remove redundant chunk bounds checks added by fuzz-patch-1. * S3M: remove duplicate channel panning table check. * ULT: remove duplicate event bounds check. Konstanty#73
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jan 31, 2022
* OKT: numerous alignment/big endian fixes. * OKT: add missing chunk size bounds checks. * OKT: remove redundant chunk bounds checks added by fuzz-patch-1. * S3M: remove duplicate channel panning table check. * ULT: remove duplicate event bounds check. Konstanty#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to remove some redundant checks from #66 and #67 (favoring the ones originating from oob_read_fixes where relevant). The Oktalyzer loader was also missing chunk size bounds checks and has serious alignment/endian issues that neither patch addressed. These all should be resolved by this, but it's not necessarily the cleanest or best way.
Note: I put
#pragma pack(1)on the structs since I didn't notice anything preventingModPlug_Loadfrom being given an unaligned pointer, which seems like a plausible thing a user could do.