Fix more issues from the fuzz-patch-1/oob_read_fixes merge. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MDL: tweaked oob_read_fixes check at 305 to break from loop. * MDL: oob_read_fixes check at 313 and fuzz-patch-1 check at 309 are redundant. Removed 313 since 309 is outside of the loop. * MT2: the oob_read_fixes check at line 291 was kind of broken. Replaced with the fuzz-patch-1 variant of that check. * MT2: combine the two checks on line 563.
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jan 29, 2022
* MDL: tweaked oob_read_fixes check at 305 to break from loop. * MDL: oob_read_fixes check at 313 and fuzz-patch-1 check at 309 are redundant. Removed 313 since 309 is outside of the loop. * MT2: the oob_read_fixes check at line 291 was kind of broken. Replaced with the fuzz-patch-1 variant of that check. * MT2: combine the two checks on line 563. Konstanty#75
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jan 31, 2022
* MDL: tweaked oob_read_fixes check at 305 to break from loop. * MDL: oob_read_fixes check at 313 and fuzz-patch-1 check at 309 are redundant. Removed 313 since 309 is outside of the loop. * MT2: the oob_read_fixes check at line 291 was kind of broken. Replaced with the fuzz-patch-1 variant of that check. * MT2: combine the two checks on line 563. Konstanty#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More stuff that needed attention from #66 and #67, from the loaders I didn't check for that patch. I had to turn off UBSan for testing these loaders because it seems that the MT2 loader (and maybe others) also has alignment issues like Oktalyzer did.
There will be a third patch for the MIDI loader, after which I think all of the merge conflicts between those two branches should be resolved. I split it off of this patch because there are no clean options for fixing it.