feat: Generate stories from @Preview composables by congvc-dev#96
Merged
Conversation
eymar
approved these changes
Oct 8, 2025
Collaborator
eymar
left a comment
eymar
left a comment
There was a problem hiding this comment.
Thank you!
As I understand:
- the new compiler plugin is not added to publication (the maven-publish plugin is not applied in preview-processor)
- The preview-processor compiler plugin is not applied automatically. A potential user will have to apply it manually (like in a gallery-demo).
And another concern would be that the visibility of the functions is changed and they can appear in the public API (can be a surprise for a library developer).
But since the plugin is not applied implicitly right now, it's not a big concern.
We can improve after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the exact MR as @congvc-dev created (#70) but rebased (to eliminate conflicts) and with Java version set to 17