Conversation
jnation3406
requested changes
May 4, 2026
Contributor
jnation3406
left a comment
jnation3406
left a comment
There was a problem hiding this comment.
Just one main comment on pulling out the re-used lightcurve function into a utils class, so operations and analysis dont import eachother
| from datalab.datalab_session.utils.file_utils import get_hdu | ||
| from datalab.datalab_session.utils.filecache import FileCache | ||
| from datalab.datalab_session.utils.flux_to_mag import flux_to_mag | ||
| from datalab.datalab_session.data_operations.light_curve import light_curve |
Contributor
There was a problem hiding this comment.
I don't think we want operations importing from analysis or vice-versa. So if there is logic that both an analysis task and operation want to share, it should be in the utils dir and used by both.
Contributor
Author
There was a problem hiding this comment.
oh well, analysis doesn't even use light curve now! so I could just delete this import and its fake use
jnation3406
approved these changes
May 4, 2026
Contributor
jnation3406
left a comment
jnation3406
left a comment
There was a problem hiding this comment.
No need to re-request review if the changes are simple!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE: Light Curve Operation
Refactors light curve logic from
variable_starand turns it into its own operation.