Minor auto-refactor code cleanup on a massive scale

[labkey-jeckels]

Rationale

We can cleanup tens of thousands of warnings across our codebase with IntelliJ's autorefactors. In some cases, this adopts newer, leaner syntax. In others, it simply removes code that's not serving any purpose.

Related Pull Requests

• Minor auto-refactor code cleanup on a massive scale platform#6742

Changes

• Auto-refactors
  • Eliminate redundant toString()
  • Eliminate redundant cast
  • Empty JavaDoc annotations
  • Member variable can be final
  • length() and size() -> isEmpty()
  • Add missing @OverRide
  • Class can be static
  • Remove unused imports
  • toArray() passed array length
  • Remove unnecessary semicolon
  • Explicit type syntax can be replaced by <>
  • Redundant access modifiers
  • Remove redundant initializer
  • "".equals() -> isEmpty()
  • StringBuilder can be replaced by String
  • Fix misordered arguments to assertEquals()
  • StringUtils.defaultString() - Objects.toString()
  • Cast can be replaced with pattern variable
  • Collapse identical catch blocks
  • Type may be primitive
• Manual fixups
  • Delete unused GWT code
  • Improve generics
  • new UnexpectedException() -> UnexpectedException.wrap()

[bbimber]

That's interesting how it did the refactor here. Assigning a value to templateId is unnecessary, which it found. However, leaving line 139 as-is should not happen. Line 139 can be removed.

[bbimber]

@labkey-jeckels : do you want me to make this edit here, or will you do these on your machine?

[labkey-nicka]

That's interesting how it did the refactor here. Assigning a value to templateId is unnecessary, which it found. However, leaving line 139 as-is should not happen. Line 139 can be removed.

It doesn't modify the right-hand side of the operation since it doesn't know if there are side-effects (in general).

[labkey-jeckels]

I removed the line completely. I agree with Nick's assessment of why the refactor made the edit it did. I've seen cases where it completely removed method calls that were part of unused assignment statements, but only in cases where it knew there was no side effect, like a trivial get method.

[bbimber]

please see comment about AssayHelper line 139