Fix usage queries to reference Created (not Date)#256
Conversation
labkey-jeckels
left a comment
There was a problem hiding this comment.
For user-defined queries, should we also make these audit log tables backwards compatible with Date? It could be handled in DefaultAuditTypeTable.resolveColumn()
I was hoping to simplify and get rid of all the legacy names, but yeah, it looks like there are a lot of queries selecting "Date". |
I did a quick search and outside of the ones covered here, I did not see anything obvious in any of the BimberLab modules. EHR has one (which you might have already seen in a different PR). If you do go with Josh's option, could that code easily log an error/warning to the server log, notifying TeamCity and/or admins to change it? I'm not sure if this is really required after this PR though. |
Thanks for looking... I do have a fix for ehr/DemographicsDeleted.sql: LabKey/ehrModules#1005. Unnecessary after adding a legacy alias for "Date", but it's done. I'm planning to leave that "Date" alias in place "forever", so I don't think we need to warn. |
Rationale
Fix query validation during folder import in ONPRC tests. "Date" is no longer a column in audit event tables.
Related Pull Requests