Skip to content

Stale element fix in tests #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-martyp wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Stale element fix in tests #655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d156f
submit final fix
labkey-martyp Feb 7, 2026
66d83d6
birth form cleanup
labkey-martyp Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nirc_ehr/test/src/org.labkey.test/tests.nirc_ehr/NIRC_EHRTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,8 @@ public void testBirthForm()
births.setGridCellJS(1, "date", now.minusDays(1).format(DateTimeFormatter.ofPattern(DATE_TIME_FORMAT_STRING)));
births.setGridCell(1, "Id", bornAnimal);
births.setGridCell(1, "cage", "C3");
births.setGridCell(1, "Id/demographics/species", "Cebus apella CAP");
births.setGridCell(1, "Id/demographics/gender", "female");
births.setGridCell(1, "project", "795644");
births.setGridCell(1, "birthProtocol", "protocol101");
submitForm("Submit Final", "Finalize");
Expand Down Expand Up @@ -1307,7 +1309,8 @@ private void verifyOrchardFileGenerated(String animalId)
private void submitForm(String buttonText, String windowTitle)
{
//Give time for errors to disappear after validation
longWait().until(ExpectedConditions.invisibilityOfElementWithText(Locator.tag("div"), "The form has the following errors and warnings:"));
Locator.tagContainingText("div", "The form has the following errors and warnings:")
.waitForElementToDisappear(longWait());
Locator submitFinalBtn = Locator.linkWithText(buttonText);
shortWait().until(ExpectedConditions.elementToBeClickable(submitFinalBtn));
Window<?> msgWindow;
Expand Down