Support non-user-visible rendering of HTML comments in Markdown #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
reviewed
Jan 30, 2026
| public void testMdHeadingToHtml() | ||
| { | ||
| MarkdownService markdownService = MarkdownService.get(); | ||
| MarkdownService markdownService = new MarkdownServiceImpl(); |
Contributor
There was a problem hiding this comment.
Just curious... why this change?
Contributor
Author
There was a problem hiding this comment.
This lets the test run as a standalone unit test, not needing to be run inside the webapp.
…1_fb_818_markdownComments
labkey-adam
approved these changes
Jan 30, 2026
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
Looks like WikiCspTest was failing with CSP errors on this branch (before my merge from develop). I didn't investigate. https://teamcity.labkey.org/buildConfiguration/LabKey_2511Release_Community_ModuleSuites_WikiSqlserver/3826615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Markdown standards, such as they exist, generally expect that non-Markdown syntax will be passed through as-is to the rendered HTML.
Changes